Skip to content

fix(cli) use vp fmt instead of bin in create#972

Merged
fengmk2 merged 2 commits intovoidzero-dev:mainfrom
Salnika:fix-cli-create-fmt-call
Mar 17, 2026
Merged

fix(cli) use vp fmt instead of bin in create#972
fengmk2 merged 2 commits intovoidzero-dev:mainfrom
Salnika:fix-cli-create-fmt-call

Conversation

@Salnika
Copy link
Contributor

@Salnika Salnika commented Mar 16, 2026 •
edited
Loading

vp create was formatting newly scaffolded projects by invoking oxfmt directly instead of going through vp fmt. I
n Yarn PnP projects, that bypassed Vite+'s normal config resolution path, so oxfmt failed to load the generated vite.config.ts

The fix changes the formatting step to call vp fmt --write instead of executing oxfmt directly.

$> vp create --verbose
...

Wrote editor config to .vscode/settings.json

Wrote editor config to .vscode/extensions.json

Rewrote imports in one file

  synth-tools/vite.config.ts

✔ Merged staged config into synth-tools/vite.config.ts

✔ Git hooks configured
◇ Dependencies installed

◇ Format failed




Failed to load configuration file.
/Users/USER/workspace/perso/projects/web/synth-tools/vite.config.ts
Ensure the file has a valid default export of a JSON-serializable configuration object.


You may need to run "vp fmt --write" manually in /Users/User/workspace/perso/projects/web/synth-tools
◇ Scaffolded synth-tools with Vite+ monorepo
• Node 24.14.0  yarn 4.12.0
✓ Dependencies installed in 2.7s
→ Next: cd synth-tools && vp dev apps/website

@netlify
Copy link

netlify bot commented Mar 16, 2026

✅ Deploy Preview for viteplus-preview canceled.

Name Link
🔨 Latest commit ff8b8be
🔍 Latest deploy log https://app.netlify.com/projects/viteplus-preview/deploys/69b82e1a58f5be0008c04b33

@netlify
Copy link

netlify bot commented Mar 16, 2026 •
edited
Loading

✅ Deploy Preview for viteplus-preview canceled.

Name Link
🔨 Latest commit 8d61bd9
🔍 Latest deploy log https://app.netlify.com/projects/viteplus-preview/deploys/69b8c336d6dd150008124dd6

fengmk2
fengmk2 approved these changes Mar 17, 2026
View reviewed changes
Copy link
Member

@fengmk2 fengmk2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. I will manually run through the tests, and will merge after they pass!

@fengmk2
Copy link
Member

fengmk2 commented Mar 17, 2026

After my testing, the yarn pnp issue still exists #640

But this is unrelated to this PR fix, I will merge it

@fengmk2 fengmk2 merged commit 4d678df into voidzero-dev:main Mar 17, 2026
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fengmk2 fengmk2 fengmk2 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Salnika @fengmk2